Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: residual depth #265

Conversation

DrumsnChocolate
Copy link

No description provided.

@DrumsnChocolate
Copy link
Author

whoops, meant to open this on my own fork 😉

@DrumsnChocolate DrumsnChocolate deleted the feature/residual_depth branch October 1, 2024 10:11
@DrumsnChocolate
Copy link
Author

@philipperemy I've forked your project and moved to python 3.12 because I want to explore the performance of the TCN in one of my own projects where I'm already using 3.12. I chose simply dropping the dependency on tensorflow-addons, which involved removing the option for WeightNormalization (I think for my project the other two normalization options are definitely sufficient).

If you want to support python 3.12 (either without weightnormalization or by annexing it from tensorflow-addons in some way) or if you want to stay at 3.10 for now but still introduce a parameter for residual depth (like I'm doing here), I'm happy to contribute.

@DrumsnChocolate DrumsnChocolate restored the feature/residual_depth branch October 1, 2024 10:19
@philipperemy
Copy link
Owner

Hey, I guess we can drop the dependency on tensorflow-addons. That's a good idea. We don't need to support weightnormalization anymore. Or if there's any other easy way.. Can you make a PR? It'd be appreciated!

@DrumsnChocolate DrumsnChocolate deleted the feature/residual_depth branch October 2, 2024 14:54
@DrumsnChocolate
Copy link
Author

I opened a PR: #266 if you have any remarks, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants